Hi Sheldon:

Sorry for replying late. After checking the business process and screen shot you uploaded in support case, we figured out that you may need to update two places to make it work:

1: In LookupRules, Rule1, section 3, swift the conditions. That is, make "Stock Code" in front of "Sales Order Number".

The reason is: "Auto fill" button will be added behind the last condition.

If we put "Stock Code" first and "Sales Order Number" second, the "Auto fill" button will actually appear behind "Sales Order Number" line. Then function tableAutofill() will not be triggered because there is no button.autofill within ".tblstock" scope. 

2. Update

$('.tblstock').change(tableAutofill);

into

$('.tblstock').on('change','.stockCode',tableAutofill);

The reason is: when we run the autofill, the function will look up and change every target which is within the ".tblstock" scope. Then the ".tblstock" hear the change and run function tableAutofill() again. Finally it becomes an infinity loop. 

Here we add the ".stockCode" to the change, which means that we only run the function tableAutofill() if the change happens within ".stockCode" scope. Then all the changes caused by targets will not trigger the function tableAutofill().

Hope it can work now. Let me know if you have any problem :)

Hi Li,

Thank you for the feedback. I have implemented your suggestions and have managed to get it working. I rebuilt all my lookup rules, since it seems the conversion from 9.1 to 9.2 may have mixed them up a bit. Originally, my Autofill was attached to the correct field.

Once the lookups were working properly, I then used your script for monitoring a change event. I did not know you could monitor the table field change in this way and it offers alot more flexibility.

Once that was done, I also had to fiddle with the automatic trigger for the Autofill Button. I used the new "lookup" event attached to the StockCode field in the table, and it worked great. I will post my updated coded here for others to see as well.

Thanks for your help.

$(document).ready(function () {
  
  //Automatically trigger autofill button
 // $('.lookupCondition input').blur(autofill);

  //$('.tblstock').change(tableAutofill);
  $('.tblstock').on('change','.stockCode',sumtotalcredit);
  $('.tblstock').on('change','.listPrice',sumtotalcredit);
  $('.tblstock').on('change','.qtyReturned',sumtotalcredit);
  $('.tblstock').on('lookup','.stockCode',tableAutofill);
  //$('.PSNumber').change(tableAutofill);
  
  function tableAutofill() {

  $('.tblstock tbody tr').each(function () {

  $(this).find('.autofill').trigger('click');
   
});

}

function autofill() {

$('.autofill').trigger('click');  

}

  function sumtotalcredit() 
  {

    var totalcredit = 0;
    var totalVAT = 0;
    var subtotalcredit = 0;
   
    $('.tblstock tbody tr').each(function ()
                                    {
                                      
                                      var uom = $(this).find('.uom input').val() * 1;
                                      var subtotal = 0;
                                      var listPrice = $(this).find('.listPrice input').val() * 1;
                                      var qtyOrdered = $(this).find('.qtyOrdered input').val() * 1;
                                      qtyOrdered = Math.round(qtyOrdered);
                                      var qtyReturned = $(this).find('.qtyReturned input').val() * 1;
                                      qtyReturned = qtyReturned.toFixed(0);
                                      $(this).find('.qtyReturned input').val(qtyReturned);
                                      //Remove decimals from QTY ordered
                                      $(this).find('.qtyOrdered input').val(qtyOrdered);

                                    
                                      var disc = $(this).find('.disc input').val()/100*1;
                                      var totalPrice =0;
                                      //Calculate total price
                                      
                                      
                                      
                                      //Calculate Discount if more than 0%
                                      if (disc > 0)
                                      {
                                        disc = 1 - disc;
                                        if(uom == 100)
                                      	{
                                        	totalPrice = listPrice/100*qtyOrdered*disc;                                    
                                      	}
                                        else{totalPrice = listPrice * disc;}
                                      }
                                      else{totalPrice = listPrice/100;}                                   
                                      
                                      var totalPriceRounded = totalPrice.toFixed(2);
                                      $(this).find('.totalPrice input').val(totalPriceRounded);
                                      
                                      subtotal += totalPrice / qtyOrdered * qtyReturned;
                                      subtotal = subtotal.toFixed(2);
                                      
  
                                      subtotalcredit += subtotal *1;
                                      //subtotalcredit = subtotalcredit.toFixed(2);
                                      $(this).find('.stock_subtotal input').val(subtotal);                                      
                                    });//end for each tblstock function
    
   
    subtotalcredit = subtotalcredit.toFixed(2);
    $('.credit_subtotal input').val(subtotalcredit);
    $('.vat input').val(totalVAT);
    totalcredit += subtotalcredit *1; 
    totalcredit = totalcredit.toFixed(2);
    //totalcredit = totalcredit.toFixed(2);
    $('.totalCredit input').val(totalcredit);
    
  }//end sumtotalcredit function

  
});//end ready and end function

Hi Li,

Thank you for the tips, it definitely helps to make the code shorter. However, I find it difficult to manage the order in which events take place, in order to get the right outcome. I have tried your specific suggestions, but find that the "sumtotalcredit" function wouldn't get a chance to do it's job properly and create a subtotal.

I ended up with this combination of event handlers that give me the result I need. I don't think it's the best for performance, but all my "formatting" and calculations end up the way I need it to. This is especially true when there are multiple rows in my table that need to be calculated. When adding a row, then all rows are refreshed with the Autofill and each row is recalculated again. I specifically targeted some of the fields on which the lookup is performed to try and get the order in which the the Autofill and the calculations work. Maybe it's by chance, but the order in which they work seems to give me the right results.

  //Automatically trigger autofill button
  $('.tblstock').on('change','.stockCode, .listPrice, .qtyReturned',sumtotalcredit);
  $('.tblstock').on('lookup','.stockCode, .qtyReturned',tableAutofill);
   $('.tblstock').on('lookup','.qtyReturned',sumtotalcredit);

Hey Sheldon:

Maybe our test case is a little bit different from your business process, and that causes the different results with the same piece of code. We are sorry for any improper advice before :/

It is always better to listen to specific targets and we are glad your method can work properly.

Please let us know if you have any question :) 

Hi Li,

Thank you very much for the advice you've offered. The way you've explained the use of the event handlers has helped my understand alot better and helped me with my solution. I didn't know it could work that way before.

Thanks

Sheldon